Run GitHub test actions on contributor forks.#325
Merged
Conversation
theengineear
force-pushed
the
test-forks
branch
from
a60ab3b to
cdcd5d8
Compare
Previously, the action in “test.yaml” only ran on branch pushes from maintainers. This was mostly fine, but contributors weren’t getting the same feedback about linting, typing, and testing. Now, all PRs will cause tests to run. Plus, we continue to specifically target our “main” branch updates as a sanity check. Closes #324.
theengineear
force-pushed
the
test-forks
branch
from
cdcd5d8 to
ad6f4a0
Compare
theengineear
commented
Sep 23, 2025
| name: Check Main | ||
| on: | ||
| push: | ||
| branches: [main] |
Collaborator
Author
There was a problem hiding this comment.
Continue to run tests on main (e.g., after a PR is merged) as a sanity check.
theengineear
commented
Sep 23, 2025
| # Run tests on pull requests, including from forks. | ||
| name: Check Pull Request | ||
| on: | ||
| pull_request |
Collaborator
Author
There was a problem hiding this comment.
By default GitHub will target the opened, synchronize, or reopened types (so we don’t need to write that all out). See pull_request docs.
theengineear
commented
Sep 23, 2025
| // } | ||
| static #removeWithin(node) { | ||
| node.replaceChildren() | ||
| node.replaceChildren(); |
Collaborator
Author
There was a problem hiding this comment.
This was what caused the lint check to fail. Now that we run all this for PRs — we would expect to catch this sort of thing in review!
Collaborator
Author
|
FYI @klebba — Small change to make sure we’re running tests on all PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the action in “test.yaml” only ran on branch pushes from maintainers. This was mostly fine, but contributors weren’t getting the same feedback about linting, typing, and testing.
Now, all PRs will cause tests to run. Plus, we continue to specifically target our “main” branch updates as a sanity check.
Closes #324.